[PATCH] D60784: [Object][XCOFF] Add intial support for parsing/dumping section header table.

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 18 08:17:36 PDT 2019


sfertile updated this revision to Diff 195746.
sfertile added a comment.

1. Addressed @hubert.reinterpretcast  comments
2. Added the compiler and source used to generate the object file used in the test.
3. Added test coverage of long section names (ie names of length 8 that are not null terminated)
4. removed the `checkSize` function as there were no longer any users.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60784/new/

https://reviews.llvm.org/D60784

Files:
  llvm/include/llvm/BinaryFormat/XCOFF.h
  llvm/include/llvm/Object/XCOFFObjectFile.h
  llvm/lib/Object/XCOFFObjectFile.cpp
  llvm/test/tools/llvm-objdump/Inputs/xcoff-long-sec-names.o
  llvm/test/tools/llvm-objdump/Inputs/xcoff-section-headers-truncate.o
  llvm/test/tools/llvm-objdump/Inputs/xcoff-section-headers.o
  llvm/test/tools/llvm-objdump/xcoff-section-headers.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60784.195746.patch
Type: text/x-patch
Size: 11418 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190418/11dcae9d/attachment.bin>


More information about the llvm-commits mailing list