[PATCH] D60602: [InferAddressSpaces] Add AS parameter to the pass factory

[Anastasia Stulova via Phabricator via llvm-commits]

Anastasia added a comment.

In D60602#1471614 <https://reviews.llvm.org/D60602#1471614>, @kpet wrote:

> This doesn't fix anything broken in LLVM but I did check that it didn't break any of the existing tests either :).
>
> I did think about adding a test but in this case testing the new parameter would require a full C++ app that makes use of the pass and grep'ing in the tests returned zero matches for similar tests.


Ok, we don't add C++ tests to llvm. But would it be possible to extract an `.ll` file generated from C++ (may be with some amendments) and run opt with the pass enabled?

Then you could check for IR to be expected.  Are you expecting a certain IR pattern to occur with your change?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60602/new/

https://reviews.llvm.org/D60602