[PATCH] D60838: [x86] use psubus for more vsetcc lowering (PR39859)

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 18 06:29:27 PDT 2019


spatel marked an inline comment as done.
spatel added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:19747
 }
 
+/// Given a simple buildvector constant, return a new vector constant with each
----------------
craig.topper wrote:
> Would it make sense to merge this with decrementVectorConstant using a flag or something?
Yes - I just did the slightly quicker copy/paste version first to see if there were any objections to the direction. Will update.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60838/new/

https://reviews.llvm.org/D60838





More information about the llvm-commits mailing list