[PATCH] D60602: [InferAddressSpaces] Add AS parameter to the pass factory

Thu Apr 18 06:18:16 PDT 2019

Anastasia added a comment.

In D60602#1471588 <https://reviews.llvm.org/D60602#1471588>, @Anastasia wrote:

> In D60602#1471553 <https://reviews.llvm.org/D60602#1471553>, @kpet wrote:
>
> > The pass is used by the AMDGPU and NVPTX backends. All their tests are passing with this change.
>
>
> Yes, but they were passing before? Or is this fixing any bug in the existing tests?
>
> If the change is adding functionality it  is a good practice to add a test demonstrating its use. Otherwise, someone can commit something later that break the functionality and we might not have any way to detect that it's broken.

PS, there are situation in which some functionality can't be tested and then it can be acceptable to commit w/o a test. But I don't know if this is the case. I am just asking whether it has been analyzed.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60602/new/

https://reviews.llvm.org/D60602