[PATCH] D60852: Fix for bug 41512: lower INSERT_VECTOR_ELT(ZeroVec, 0, Elt) to SCALAR_TO_VECTOR(Elt) for all SSE flavors

Serge Preis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 18 03:54:04 PDT 2019


Serge_Preis added a comment.

In D60852#1471378 <https://reviews.llvm.org/D60852#1471378>, @RKSimon wrote:

> Your test cases need to be a lot simpler - I'd recommend looking at buildvec-insertvec.ll and possibly adding your tests to that file instead of adding this new file.


The problem is that in tiny kernel llvm behaves as I expect it to, while in a loop it underperforms: https://gcc.godbolt.org/z/PljujX -- compare Sum2 and Loop() code generation.
I will do my best to minimize the case.

> You will need to use the utils/update_llc_test_checks.py script to autogenerate your codegen checks as well.

Ok, I will look into this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60852/new/

https://reviews.llvm.org/D60852





More information about the llvm-commits mailing list