[PATCH] D60131: [ELF] Change default output section type to SHT_PROGBITS

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM

> No, the actual issue is that a non-empty PT_LOAD segment that starts with an empty symbol only section does not have a file offset that is congruent modulo the page size. As a result, the output is not a valid ELF.

Got it, thanks.



================
Comment at: test/ELF/linkerscript/symbol-only-align.test:2-5
+# RUN: echo '.text; \
+# RUN:        ret;  \
+# RUN:       .data; \
+# RUN:       .quad 0' > %t.s
----------------
andrewng wrote:
> ruiu wrote:
> > nit: You can just write them in a single line.
> I deliberately put them on separate lines for readability. Would you prefer a single line?
Yeah, I'd prefer not to contain too many space characters in a test file. The result of the concatenation is a long single line, as an escaped newline is removed before given to a command. If something goes wrong, that resulted in something like this, which isn't easy to read:

  SECTIONS { foo                                                bar                                                baz                                                foo                                                bar                                                baz                        }
  .                                                                                                                                                                                                                                            ^ invalid parameter

For this particular case, the concatenated line wouldn't be that long, but in general, I'd like to not use too many escaped newlines.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60131/new/

https://reviews.llvm.org/D60131