[PATCH] D50407: Remove obsolete policy settings

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 17 18:37:59 PDT 2019


smeenai added subscribers: phosek, beanz, smeenai.
smeenai added inline comments.
Herald added a project: LLVM.


================
Comment at: llvm/trunk/CMakeLists.txt:16
 
-cmake_policy(SET CMP0056 NEW)
-
----------------
This removal was incorrect. https://cmake.org/cmake/help/v3.4/policy/CMP0056.html says "Unlike most policies, CMake version 3.4.3 does not warn by default when this policy is not set and simply uses OLD behavior (and even the latest version's documentaion says the same).

In general, @beanz, @phosek, @mgorny and I make good reviewers for CMake changes.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D50407/new/

https://reviews.llvm.org/D50407





More information about the llvm-commits mailing list