[PATCH] D60600: [InstCombine] Fix a vector-of-pointers instcombine undef bug.

[Philip Reames via Phabricator via llvm-commits]

reames requested changes to this revision.
reames added a comment.
This revision now requires changes to proceed.

I think you might be overcomplicating this.  I'd suggest the following:

1. scan all index types for a gep
2. run current code, but if any operand was gep, skip the recursive call on the operand

It's slightly less powerful, but correct, and easy.  And frankly, optimize geps of struct types is probably rare enough we don't care.

p.s. Agreed on the location of test file, please add to existing tests.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60600/new/

https://reviews.llvm.org/D60600