[PATCH] D60650: [LVI][CVP] Constrain values in with.overflow branches

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

I haven't looked at LVI much, but judging from the git log, nobody else has done that recently either.

The logic looks right, and the tests are great. LGTM.



================
Comment at: llvm/lib/Analysis/LazyValueInfo.cpp:1140
+static ValueLatticeElement getValueFromOverflowCondition(
+    Value *Val, WithOverflowInst *WO, bool isTrueDest) {
+  // TODO: This only works with a constant RHS for now. We could also compute
----------------
I see that the lower-case variable "isTrueDest" is carried over from existing code, but I think it should be changed to conform with the current guidelines and the formatting of other variables (unless the lowerCamelCase proposal is going forward...).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60650/new/

https://reviews.llvm.org/D60650