[PATCH] D60793: [Evaluator] Walk initial elements when handling load through bitcast

Wed Apr 17 08:12:07 PDT 2019

rob.lougher added a comment.

In D60793#1469812 <https://reviews.llvm.org/D60793#1469812>, @evgeny777 wrote:

> I wonder if it's possible to stop using `MutatedMemory` for checks in `ComputeLoadResult` and instead start using separate map which can also be filled 
>  in `EvaluateBlock`. In this new map you can use bitcast (or even first operand of bitcast) as a key.

"MutatedMemory" is only used to hold evaluated store values. Using the bitcast as a key would be dangerous because we could then get different values for the same memory location (via different pointer types). Currently, the code ensures that there is only one value for each location, which is the most recent.

> Also please strip your patch from unrelated changes for now to make it easier to read.

Done (see revised patch). Thanks for the review.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60793/new/

https://reviews.llvm.org/D60793