[PATCH] D60755: [NFCI] Improve efficiency of isPotentiallyReachableFromManyDomTree.

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 17 08:55:36 PDT 2019


kuhar added a comment.

IMO you could introduce df_iterator_tree_storage by a slight modification to the default one:

  // df_iterator_storage - A private class which is used to figure out where to
  // store the visited set.
  template<class SetType, bool External>   // Non-external set
  class df_iterator_storage {
  public:
    SetType Visited;
  };

Where your custom SetType does nothing on insertion and always returns that count is 0. Then you could potentially give it an alias like `df_tree_iterator`, or some better name.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60755/new/

https://reviews.llvm.org/D60755





More information about the llvm-commits mailing list