[PATCH] D59917: [SelectionDAG][FIX] Allow "returned" arguments to be bit-casted

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 17 06:13:26 PDT 2019


arsenm added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:8948-8949
+        assert((CLI.RetTy == Args[i].Ty ||
+                CLI.RetTy->isPointerTy() && Args[i].Ty->isPointerTy()) &&
+               RetTys.size() == NumValues && "unexpected use of 'returned'");
         // Before passing 'returned' to the target lowering code, ensure that
----------------
Maybe this should also assert that the address spaces match? I don't know if the verifier checks this or not, but it should


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59917/new/

https://reviews.llvm.org/D59917





More information about the llvm-commits mailing list