[PATCH] D60816: [llvm-symbolizer] Unhide and document the '-output-style' option

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 17 05:21:39 PDT 2019


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with a couple of minor comments.



================
Comment at: docs/CommandGuide/llvm-symbolizer.rst:133
+
+  Specify the preffered output style. Defaults to ``LLVM``. When the output
+  style is set to ``GNU``, the tool follows the style of GNU's **addr2line**.
----------------
preffered -> preferred


================
Comment at: docs/CommandGuide/llvm-symbolizer.rst:135
+  style is set to ``GNU``, the tool follows the style of GNU's **addr2line**.
+  The differences from the default style are the following:
+  
----------------
I think you can remove "the following". Replace "default" with "LLVM".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60816/new/

https://reviews.llvm.org/D60816





More information about the llvm-commits mailing list