[PATCH] D60602: [InferAddressSpaces] Add AS parameter to the pass factory

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

This is still requiring the TTI as a dependency, so I don't understand what this solves?



================
Comment at: include/llvm/Transforms/Scalar.h:383
 // on the target.
 //
+FunctionPass *createInferAddressSpacesPass(unsigned AS = ~0u);
----------------
Parameter name should be more descriptive. The comment also needs to be updated


================
Comment at: lib/Transforms/Scalar/InferAddressSpaces.cpp:631
+  if (FlatAddrSpace == UninitializedAddressSpace) {
+
+    FlatAddrSpace = TTI.getFlatAddressSpace();
----------------
Extra blank line here. Also should sink the getAnalysis into here


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60602/new/

https://reviews.llvm.org/D60602