[PATCH] D60457: [CodeGen] Fixed de-optimization of legalize subvector extract

Tim Renouf via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 17 03:12:38 PDT 2019


tpr marked 3 inline comments as done.
tpr added inline comments.


================
Comment at: test/CodeGen/AMDGPU/extract_subvector_vec4_vec3.ll:4
+; GCN-LABEL: body:
+; GCN-NOT: %stack
+
----------------
arsenm wrote:
> I wouldn’t trust this to check this, a generated check would be better
Not really sure what you're suggesting, but I hope this is better.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60457/new/

https://reviews.llvm.org/D60457





More information about the llvm-commits mailing list