[PATCH] D60644: [compiler-rt][builtins][sanitizers] Guard test cases with macros to run when specific version of GLIBC is detected

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht added a comment.

In D60644#1467710 <https://reviews.llvm.org/D60644#1467710>, @amyk wrote:

> @rupprecht That is true.  However, isn't it possible that a system's most up to date GLIBC version is still lower than say, GLIBC 2.23? Starting a conversation on which GLIBC versions are important can possibly be something that can be done.
>
> In terms of the `compiler_rt_logb` test failures, I edited the test to return 0 to see the failures. I see about 104 lines that are outputted, so I've attached my results here. F8695155: compiler_rt_logb_results.txt <https://reviews.llvm.org/F8695155>


Interesting, it looks like an issue when handling subnormal values. You could probably limit this to skip test cases where `x != 0.0 && (rep & exponentMask) == 0` if a bad glibc is detected, so that at least the normal floating point values are checked. I don't have an old glibc installed to try it out though :)

It might be overkill to do that though. I'm fine with the logb test change. Not familiar with the other tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60644/new/

https://reviews.llvm.org/D60644