[PATCH] D60324: [llvm-objcopy] Add switch to allow removing referenced sections

Wed Apr 17 02:41:42 PDT 2019

grimar added inline comments.

================
Comment at: tools/llvm-objcopy/ObjcopyOpts.td:13
+def allow_broken_dependencies
+    : Flag<["-", "--"], "allow-broken-dependencies">,
+      HelpText<"Allow llvm-objcopy to remove sections even if it would leave "
----------------
jhenderson wrote:
> grimar wrote:
> > Not strong opinion here, but `allow-broken-dependencies` looks like a bit too long option name.
> > Will `allow-broken-deps`/`allow-broken-links` sound better?
> I don't like abbreviations in switches, because I don't know what "deps" stands for. However, `allow-broken-links` is reasonable. I was thinking this switch could also be used for other relationships via sh_info, but I don't know of any yet where this is needed.
I also did not find any valid use case.
I.e. looking at the table of how sh_info can be used (https://docs.oracle.com/cd/E19683-01/816-1386/chapter6-94076/index.html),
it does not seem that it is fine to allow broken dependencies there perhaps. 

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60324/new/

https://reviews.llvm.org/D60324