[PATCH] D60770: [llvm-symbolizer] Make the output with `-output-style=GNU` closer to addr2line's

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 17 02:06:37 PDT 2019


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, but I wouldn't mind a second pair of eyes on the new logic (@rupprecht?), as I'm not really familiar with how the `DILineInfo` class works.



================
Comment at: test/tools/llvm-symbolizer/output-style-empty-line.test:18
+
+GNU: x.c:14
+GNU-NEXT: some text2
----------------
Put a `{{$}}` at the end of this line, if you don't want it matching the column output.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60770/new/

https://reviews.llvm.org/D60770





More information about the llvm-commits mailing list