[PATCH] D60791: [CVP] Simplify umulo and smulo that cannot overflow

[Mikael Holmén via Phabricator via llvm-commits]

uabelho added a comment.

Hi,

I see crashed with this patch. E.g.

  opt -S -o - cvp_crash.ll -correlated-propagation

on

  define void @f() {
    %mul = call { i8, i1 } @llvm.umul.with.overflow.i8(i8 1, i8 2)
    ret void
  }
  
  declare { i8, i1 } @llvm.umul.with.overflow.i8(i8, i8)

gives

  opt: ../include/llvm/Support/Casting.h:264: typename cast_retty<X, Y *>::ret_type llvm::cast(Y *) [X = llvm::Instruction, Y = llvm::Value]: Assertion `isa<X>(Val) && "cast<Ty>() argument of incompatible type!"' failed.
  
  Program received signal SIGABRT, Aborted.
  
  
  (gdb) where
  #0  0x00007ffff67bbc37 in __GI_raise (sig=sig at entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
  #1  0x00007ffff67bf028 in __GI_abort () at abort.c:89
  #2  0x00007ffff67b4bf6 in __assert_fail_base (fmt=0x7ffff6909058 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=assertion at entry=0x448edf9 "isa<X>(Val) && \"cast<Ty>() argument of incompatible type!\"", file=file at entry=0x448ed5a "../include/llvm/Support/Casting.h", line=line at entry=264, function=function at entry=0x448fa5c "typename cast_retty<X, Y *>::ret_type llvm::cast(Y *) [X = llvm::Instruction, Y = llvm::Value]") at assert.c:92
  #3  0x00007ffff67b4ca2 in __GI___assert_fail (assertion=0x448edf9 "isa<X>(Val) && \"cast<Ty>() argument of incompatible type!\"", file=0x448ed5a "../include/llvm/Support/Casting.h", line=264, function=0x448fa5c "typename cast_retty<X, Y *>::ret_type llvm::cast(Y *) [X = llvm::Instruction, Y = llvm::Value]") at assert.c:101
  #4  0x0000000000d64129 in llvm::cast<llvm::Instruction, llvm::Value> (Val=0x6d8df00) at ../include/llvm/Support/Casting.h:264
  #5  0x000000000348d282 in processOverflowIntrinsic (WO=0x6d8e188) at ../lib/Transforms/Scalar/CorrelatedValuePropagation.cpp:422
  #6  0x000000000348b59f in processCallSite (CS=..., LVI=0x6d5c9d0) at ../lib/Transforms/Scalar/CorrelatedValuePropagation.cpp:438
  #7  0x000000000348a9a9 in runImpl (F=..., LVI=0x6d5c9d0, DT=0x6d8e390, SQ=...) at ../lib/Transforms/Scalar/CorrelatedValuePropagation.cpp:713
  #8  0x000000000348d874 in (anonymous namespace)::CorrelatedValuePropagation::runOnFunction (this=0x6d8d5b0, F=...) at ../lib/Transforms/Scalar/CorrelatedValuePropagation.cpp:768
  #9  0x0000000002f26e48 in llvm::FPPassManager::runOnFunction (this=0x6d8b6c0, F=...) at ../lib/IR/LegacyPassManager.cpp:1648
  #10 0x0000000002f272c5 in llvm::FPPassManager::runOnModule (this=0x6d8b6c0, M=...) at ../lib/IR/LegacyPassManager.cpp:1688
  #11 0x0000000002f27a87 in (anonymous namespace)::MPPassManager::runOnModule (this=0x6d8b1c0, M=...) at ../lib/IR/LegacyPassManager.cpp:1755
  #12 0x0000000002f2758d in llvm::legacy::PassManagerImpl::run (this=0x6d8ad20, M=...) at ../lib/IR/LegacyPassManager.cpp:1868
  #13 0x0000000002f28041 in llvm::legacy::PassManager::run (this=0x7fffffffd4e8, M=...) at ../lib/IR/LegacyPassManager.cpp:1899
  #14 0x0000000000da3a64 in main (argc=6, argv=0x7fffffffda88) at ../tools/opt/opt.cpp:901

Problem seems to be in processOverflowIntrinsic:

  static void processOverflowIntrinsic(WithOverflowInst *WO) {
    IRBuilder<> B(WO);
    Value *NewOp = B.CreateBinOp(
        WO->getBinaryOp(), WO->getLHS(), WO->getRHS(), WO->getName());
    if (WO->isSigned())
      cast<Instruction>(NewOp)->setHasNoSignedWrap();
    else
      cast<Instruction>(NewOp)->setHasNoUnsignedWrap();

when it crashes we have

  $11 = void
  (gdb) call WO->dump()
    %mul = call { i8, i1 } @llvm.umul.with.overflow.i8(i8 1, i8 2)
  (gdb) call NewOp->dump()
  i8 2

So I suppose cases where NewOp is evaluated to a constant doesn't work since then the cast<Instruction> crashes.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60791/new/

https://reviews.llvm.org/D60791