[PATCH] D60812: Don't error on CMAKE_SYSTEM_NAME=Wasi

Dan Gohman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 16 22:37:07 PDT 2019


sunfish added inline comments.


================
Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:129
     endif()
   else(FUCHSIA OR UNIX)
+    if(${CMAKE_SYSTEM_NAME} MATCHES "Wasi")
----------------
I don't know a lot about CMake, but would be better to add a predicate for `WASI` so that we can change these `FUCHSIA OR UNIX` conditions into `FUCHSIA OR UNIX OR WASI` conditions?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60812/new/

https://reviews.llvm.org/D60812





More information about the llvm-commits mailing list