[PATCH] D60690: [AArch64] Skip mask checks for masks with an odd number of elements.

Gerolf Hoflehner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 16 15:32:04 PDT 2019


Gerolf added a comment.

Could you separate size one checks are OK vs. checks that require even powers of 2? That smells like an inconsistency worth calling out explicitly.

Thanks
Gerolf



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:7553
 
+  if (NumElts > 1 && NumElts % 2 != 0)
+    return false;
----------------
This check could be the early exit at the start of the function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60690/new/

https://reviews.llvm.org/D60690





More information about the llvm-commits mailing list