[PATCH] D60789: [x86] try to widen 'shl' as part of LEA formation

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:1935
+    if (!matchAddressRecursively(NewShl, AM, Depth + 1))
+      return false;
+    break;
----------------
lebedev.ri wrote:
> What about the `insertDAGNode()` calls? We simply expect that they will be dropped afterwards?
Should we restrict this to legal scale amounts? Can we just update the addressing mode and stop instead of calling matchAddressRecursively?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60789/new/

https://reviews.llvm.org/D60789