[PATCH] D52239: [OCaml] Add OCaml APIs to access DebugLoc info

Josh Berdine via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 16 13:42:47 PDT 2019


jberdine marked 3 inline comments as done.
jberdine added a comment.

I've updated this to implement the accessors using the new DI APIs instead of the old wrapped value ones, using the functions added in D60725 <https://reviews.llvm.org/D60725> and D60795 <https://reviews.llvm.org/D60795>.

There is a big RFC point to this diff: instead of these functions, do we want to work toward a point where the OCaml bindings mirror the C ones, by adding the whole DI type hierarchy, none of which is currently present? I guess so, but would like some others' thoughts.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52239/new/

https://reviews.llvm.org/D52239





More information about the llvm-commits mailing list