[PATCH] D60792: Time profiler: optimize json output time

Anton Afanasyev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 16 13:21:22 PDT 2019


anton-afanasyev marked 2 inline comments as done.
anton-afanasyev added inline comments.


================
Comment at: llvm/lib/Support/TimeProfiler.cpp:92
     json::Array Events;
+    Events.reserve(Entries.size() + CountAndTotalPerName.size() + 1);
 
----------------
lebedev.ri wrote:
> Just do
> ```
> const size_t ExpectedEntryCount = Entries.size() + CountAndTotalPerName.size() + 1;
> Events.reserve(ExpectedEntryCount);
> ...
> assert(Events.size() == ExpectedEntryCount && "Size prediction failed");
> ```
> else they //could// drift apart.
Thanks, good point!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60792/new/

https://reviews.llvm.org/D60792





More information about the llvm-commits mailing list