[PATCH] D60470: [DWARF] Prefer larger DW_AT_low_pc when constructing aranges

Tue Apr 16 12:58:18 PDT 2019

dblaikie added a comment.

In D60470#1467875 <https://reviews.llvm.org/D60470#1467875>, @MaskRay wrote:

> > What happens if a program is linked from some objects with debug info and some objects without it?
>
> This revision doesn't change the behavior. For the address ranges with no debug info, the results remain `??:0:0` (unknown).

Ah, sorry, that's not the case I was interested in. I meant a case where two object files are linked together - one has debug info, one does not. They both have a comdat function. The non-debug info version is chosen (creating the [0, X) address range in the debug info from the other object).

If I understand it, this change is to the prioritization/resolution of ambiguities - but similar situations/bugs can arise when there is no ambiguity (because some code has no debug info - so it's not there to create an ambiguity). if I'm understanding/explaining correctly.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60470/new/

https://reviews.llvm.org/D60470