[PATCH] D60321: [llvm-readobj] Add helper functions `printVersionSymbol()`, `printVersionDefinition()` and `printVersionDependency()`

Tue Apr 16 09:05:58 PDT 2019

Higuoxing planned changes to this revision.
Higuoxing added a comment.

In D60321#1468450 <https://reviews.llvm.org/D60321#1468450>, @jhenderson wrote:

> As I'll be away next week, I've added a couple of others to help with reviewing this too.
>
> I'm not certain that the approach you've taken is quite right. There should be no need to query the `opts::Output` member from within the dumper. That's the purpose of the individual dump styles. There's barely any common code you've actually pulled out. What is the purpose of what you have done?

Sure, I will try to get rid of it.

In D60321#1468450 <https://reviews.llvm.org/D60321#1468450>, @jhenderson wrote:

> As I'll be away next week, I've added a couple of others to help with reviewing this too.

Thanks a lot. I will discuss with them.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60321/new/

https://reviews.llvm.org/D60321