[PATCH] D60771: llvm-undname: Add a -raw-input flag to pass a raw buffer to microsoftDemangle

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 16 05:49:17 PDT 2019


thakis marked an inline comment as done.
thakis added inline comments.


================
Comment at: llvm/tools/llvm-undname/llvm-undname.cpp:34
                                  cl::init(false));
+cl::opt<std::string> RawInput("raw-input", cl::Optional,
+                              cl::desc("for fuzzer data"), cl::Hidden);
----------------
hans wrote:
> when I saw "raw-input" it wasn't immediately clear to me it would refer to a filename and not just take the input as an argument
> 
> not sure if that matters at all, or if it could be named to reflect that somehow. just a thought.
Renamed to `-raw-file`, is that better?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60771/new/

https://reviews.llvm.org/D60771





More information about the llvm-commits mailing list