[PATCH] D60510: [ADT] Fix template parameter names of llvm::{upper|lower}_bound

Ilya Biryukov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 16 04:57:10 PDT 2019


ilya-biryukov added a comment.

In D60510#1467262 <https://reviews.llvm.org/D60510#1467262>, @dblaikie wrote:

> Might've made sense to separate the NFC renaming from the perfect forwarding change (& the perfect forwarding change could potentially have some matching test coverage?)


I agree, sorry about mashing them in together. That said, I was confident this wouldn't cause any trouble in practice.
What kinds of tests are you thinking about? Checking that `llvm::lower_bound` works on non-copyable types?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60510/new/

https://reviews.llvm.org/D60510





More information about the llvm-commits mailing list