[PATCH] D60698: [ARM] add target arch definitions for 8.1-M and MVE.

[Oliver Stannard (Linaro) via Phabricator via llvm-commits]

ostannard added inline comments.


================
Comment at: llvm/lib/Support/ARMAttributeParser.cpp:137
+    "ARM v7E-M", "ARM v8", nullptr,
+    "ARM v8-M Baseline", "ARM v8-M Mainline", nullptr, nullptr, nullptr,
+    "ARM v8.1-M Mainline"
----------------
SjoerdMeijer wrote:
> what are these nullptrs, and how many do we need? :-)
> More seriously, I haven't looked into this bit before, but at least a comment would be good here I guess.
The nullptrs are missing strings for "Arm v8-R", "Arm v8.1-A", "Arm v8.2-A" and "Arm v8.3-A", we should add these, but probably as a separate patch.


================
Comment at: llvm/lib/Target/ARM/ARMSubtarget.h:114
+    ARMv8r,
+    ARMv81mMainline
   };
----------------
Nit: can we add a trailing comma to tidy up the next diff?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60698/new/

https://reviews.llvm.org/D60698