[PATCH] D60376: [llvm-objdump] Align instructions to a tab stop in disassembly output

[Jordan Rupprecht via llvm-commits]

I would suggest not bothering with sed/tr at all. Can you just add literal
tab characters to the CHECK lines? I think that would be a better test
anyway.

On Tue, Apr 16, 2019 at 3:56 AM Fangrui Song via Phabricator <
reviews at reviews.llvm.org> wrote:

> MaskRay added a comment.
>
> In D60376#1467572 <https://reviews.llvm.org/D60376#1467572>, @arphaman
> wrote:
>
> > Reverted in r358459
>
>
> @phosek @arphaman
>
> > sed: 1: "y/\t/ /": transform strings are not the same length
>
> This error message was probably due to `# RUN: llvm-objdump -d
> -print-imm-hex %t | sed 'y/\t/ /' | FileCheck -strict-whitespace %s`. I
> don't have a Mac OS X, do you know if I can use the `tr` utility? I chose
> `sed` because `tr` is not listed at
> https://llvm.org/docs/GettingStarted.html#software
>
>
> Repository:
>   rL LLVM
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D60376/new/
>
> https://reviews.llvm.org/D60376
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190416/d78750a9/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4849 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190416/d78750a9/attachment.bin>