[PATCH] D60747: Remove EnableEarlyCSEMemSSA option

[Eric Christopher via Phabricator via llvm-commits]

echristo created this revision.
echristo added reviewers: hfinkel, gberry, george.burgess.iv.
Herald added subscribers: llvm-commits, hiraditya, Prazek, mcrosier, mehdi_amini.
Herald added a project: LLVM.

This has been turned on for about a year and a half now and removing it helps simplify the pass structure (though not a lot).

I didn't see much of a review either way so I don't even know if people care or want it on by default as this is literally the only place that has it on by default and it appears to have been used for GVN Hoist which is still off by default.

Thoughts? Conditionalize it on GVN Hoist? Something else?


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D60747

Files:
  llvm/lib/Transforms/IPO/PassManagerBuilder.cpp


Index: llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
===================================================================
--- llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
+++ llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
@@ -123,10 +123,6 @@
     cl::desc("Control the amount of inlining in pre-instrumentation inliner "
              "(default = 75)"));
 
-static cl::opt<bool> EnableEarlyCSEMemSSA(
-    "enable-earlycse-memssa", cl::init(true), cl::Hidden,
-    cl::desc("Enable the EarlyCSE w/ MemorySSA pass (default = on)"));
-
 static cl::opt<bool> EnableGVNHoist(
     "enable-gvn-hoist", cl::init(false), cl::Hidden,
     cl::desc("Enable the GVN hoisting pass (default = off)"));
@@ -335,7 +331,7 @@
   // Start of function pass.
   // Break up aggregate allocas, using SSAUpdater.
   MPM.add(createSROAPass());
-  MPM.add(createEarlyCSEPass(EnableEarlyCSEMemSSA)); // Catch trivial redundancies
+  MPM.add(createEarlyCSEPass(true /* Enable mem-ssa. */)); // Catch trivial redundancies
   if (EnableGVNHoist)
     MPM.add(createGVNHoistPass());
   if (EnableGVNSink) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60747.195290.patch
Type: text/x-patch
Size: 1082 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190416/452988ea/attachment.bin>