[PATCH] D60741: Remove some more unused headers from MachineFunction.h and friends.

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 15 17:33:11 PDT 2019


echristo added a comment.

In D60741#1467705 <https://reviews.llvm.org/D60741#1467705>, @dblaikie wrote:

> Sounds good to me.
>  How'd you test that the MachineMemOperand.h changes were OK? Looks like it doesn't have an implementation file, so I'm not sure it's included first in any file - which means it's harder to tell if removing headers from it is valid/keeps it standalone (since its inclusion context might be allowing it to get away without including necessary headers)


Basically grepping for Metadata and Inst things in the file itself. It's pretty short and I just read it. Always a possibility I missed something that's being gotten via transitive include though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60741/new/

https://reviews.llvm.org/D60741





More information about the llvm-commits mailing list