[PATCH] D59843: [PowerPC] Add support for __dcbf builtin

Ahsan Saghir via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 15 13:50:02 PDT 2019


saghir added a comment.

In D59843#1467249 <https://reviews.llvm.org/D59843#1467249>, @stefanp wrote:

> Looks good to me.
>  Then only thing I noticed was that in the description in the `LanguageExtensions.rst` file you use plural to refer to the chache builtins. Of course, you only added one builtin but I know that in the future you plan to add more builtins of the same type so I wouldn't worry about that wording now.


That is precisely the reason for using plural since we plan to add support for more cache builtins.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59843/new/

https://reviews.llvm.org/D59843





More information about the llvm-commits mailing list