[PATCH] D60645: [LSR] PR41445: Rewrite misses some fixup locations if it splits critical edge.

Denis Bakhvalov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 15 12:36:38 PDT 2019


dendibakh added inline comments.


================
Comment at: test/Transforms/LoopStrengthReduce/pr41445.ll:6
+define i32 @foo(i32* %A, i32 %t) {
+entry:
+  br label %loop.32
----------------
qcolombet wrote:
> Could you add a test that fall into `foundInOriginalPHI == true` if that's not already the case?
Yes, all those three cases
- found in original PHI
- found in incoming basic block PHIs
- not found anywhere
happen in this scenario.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60645/new/

https://reviews.llvm.org/D60645





More information about the llvm-commits mailing list