[PATCH] D60575: [TSan][libdispatch] Use FileCheck's --implicit-check-not=...

Julian Lettner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 15 10:39:58 PDT 2019


yln marked an inline comment as done.
yln added inline comments.


================
Comment at: compiler-rt/test/tsan/atomic_norace.cc:62
 
 // CHECK-NOT: ThreadSanitizer: data race
----------------
kubamracek wrote:
> Should this be removed now?
Some tests only have a lone CHECK-NOT: directive. For those the `--implicit-check-not` does not increase strictness. I added the --implict-check-not part for consistency (maybe someone changes te test or copies and extends it), but did not remove the check.

I can also remove lone "CHECK-NOT"s if you prefer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60575/new/

https://reviews.llvm.org/D60575





More information about the llvm-commits mailing list