[PATCH] D60031: Split tailcallelim into tailcallmark and tailcallelim

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: test/Other/opt-O3-pipeline.ll:90-101
+; CHECK-NEXT:         Natural Loop Information
+; CHECK-NEXT:         Lazy Branch Probability Analysis
+; CHECK-NEXT:         Lazy Block Frequency Analysis
+; CHECK-NEXT:         Optimization Remark Emitter
+; CHECK-NEXT:         Tail Call Marking
 ; CHECK-NEXT:         Basic Alias Analysis (stateless AA impl)
 ; CHECK-NEXT:         Function Alias Analysis Results
----------------
uenoku wrote:
> jdoerfert wrote:
> > lebedev.ri wrote:
> > > This looks weird.
> > > Does `Tail Call Marking` discard/does not preserve those analysises?
> > Good catch. It probably doesn't preserve but should. (Not only those)
> I cannot be sure whether preserved Analysis are enough.
> Is there missing analysis?
Optimization Remark Emitter seems to be recomputed, you should "preserve" that one as well.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60031/new/

https://reviews.llvm.org/D60031