[PATCH] D60093: [LoopPredication] Allow predication of loop invariant computations

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 15 09:34:28 PDT 2019


reames added a comment.

In D60093#1453993 <https://reviews.llvm.org/D60093#1453993>, @apilipenko wrote:

> 1. Since we need to fiddle with the insertion point I think we should stop using single IRBuilder which we pass around. It looks like creating a local IRBuilder is a cheap operation, so we can have local IRBuilders when we need to generate instructions. This way the insertion point will be clear from the local context.


This is handled in a separate review ( D60718 <https://reviews.llvm.org/D60718> ).  Once that's landed, I'll rebase.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60093/new/

https://reviews.llvm.org/D60093





More information about the llvm-commits mailing list