[PATCH] D60711: Removed CMake cache upgrade code from 2011

Dmitri Gribenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 15 08:06:35 PDT 2019


gribozavr created this revision.
Herald added subscribers: llvm-commits, mgorny.
Herald added a project: LLVM.

This code was added in r141266 to make a breaking change to CMake, but
still be compatible with existing cache files.  The cache files from
2011 are irrelevant today in 2019.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D60711

Files:
  llvm/cmake/modules/TableGen.cmake


Index: llvm/cmake/modules/TableGen.cmake
===================================================================
--- llvm/cmake/modules/TableGen.cmake
+++ llvm/cmake/modules/TableGen.cmake
@@ -119,15 +119,6 @@
   set(${project}_TABLEGEN "${target}" CACHE
       STRING "Native TableGen executable. Saves building one when cross-compiling.")
 
-  # Upgrade existing LLVM_TABLEGEN setting.
-  if(${project} STREQUAL LLVM)
-    if(${LLVM_TABLEGEN} STREQUAL tblgen)
-      set(LLVM_TABLEGEN "${target}" CACHE
-          STRING "Native TableGen executable. Saves building one when cross-compiling."
-          FORCE)
-    endif()
-  endif()
-
   # Effective tblgen executable to be used:
   set(${project}_TABLEGEN_EXE ${${project}_TABLEGEN} PARENT_SCOPE)
   set(${project}_TABLEGEN_TARGET ${${project}_TABLEGEN} PARENT_SCOPE)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60711.195184.patch
Type: text/x-patch
Size: 818 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190415/632d3286/attachment.bin>


More information about the llvm-commits mailing list