[PATCH] D58843: [WIP][MC][RISCV] Allow targets to defer forcing relocations

Roger Ferrer Ibanez via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 15 01:59:02 PDT 2019


rogfer01 added inline comments.
Herald added subscribers: benna, psnobl.


================
Comment at: lib/Target/RISCV/MCTargetDesc/RISCVAsmBackend.cpp:128
+  // %pcrel_lo, so they can be safely resolved.
+  for (const MCFixup *Fixup : UnknownFixups) {
+    EvaluatedFixups[Fixup] = true;
----------------
Would this hold if the resolution of https://github.com/riscv/riscv-elf-psabi-doc/issues/90 is that a `%pcrel_lo` can cross sections?

Perhaps I got this wrong, but I understand that this process is currently section-wise, so we can't say much about a `%pcrel_hi` not being referenced by any `%pcrel_lo` in the same section, can we?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58843/new/

https://reviews.llvm.org/D58843





More information about the llvm-commits mailing list