[PATCH] D60416: [libc++] Make sure that the symbol differ takes into account symbol types

[Louis Dionne via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL358408: [libc++] Make sure that the symbol differ takes into account symbol types (authored by ldionne, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Changed prior to commit:
  https://reviews.llvm.org/D60416?vs=194185&id=195176#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60416/new/

https://reviews.llvm.org/D60416

Files:
  libcxx/trunk/utils/libcxx/sym_check/diff.py


Index: libcxx/trunk/utils/libcxx/sym_check/diff.py
===================================================================
--- libcxx/trunk/utils/libcxx/sym_check/diff.py
+++ libcxx/trunk/utils/libcxx/sym_check/diff.py
@@ -14,10 +14,10 @@
 
 
 def _symbol_difference(lhs, rhs):
-    lhs_names = set((n['name'] for n in lhs))
-    rhs_names = set((n['name'] for n in rhs))
+    lhs_names = set(((n['name'], n['type']) for n in lhs))
+    rhs_names = set(((n['name'], n['type']) for n in rhs))
     diff_names = lhs_names - rhs_names
-    return [n for n in lhs if n['name'] in diff_names]
+    return [n for n in lhs if (n['name'], n['type']) in diff_names]
 
 
 def _find_by_key(sym_list, k):


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60416.195176.patch
Type: text/x-patch
Size: 689 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190415/2361cccd/attachment-0001.bin>