[PATCH] D60609: Use native llvm JSON library for time profiler output

Anton Afanasyev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 15 05:53:59 PDT 2019


anton-afanasyev marked 3 inline comments as done.
anton-afanasyev added inline comments.


================
Comment at: llvm/lib/Support/TimeProfiler.cpp:90
+
+      Events.push_back(json::Object{
+          {"pid", 1},
----------------
anton-afanasyev wrote:
> lebedev.ri wrote:
> > `emplace_back()` doesn't work?
> It works (for explicitly given cons), I've changed it in a separate review: https://reviews.llvm.org/D60663
Oops, that's another `push_back()`, I'm wrong.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60609/new/

https://reviews.llvm.org/D60609





More information about the llvm-commits mailing list