[PATCH] D58983: DAG: propagate whether an arg is a pointer for CallingConv decisions.

Tim Northover via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 15 05:03:20 PDT 2019


t.p.northover closed this revision.
t.p.northover marked an inline comment as done.
t.p.northover added a comment.

Thanks, it's r358399.



================
Comment at: llvm/include/llvm/CodeGen/TargetCallingConv.h:52
 
+    unsigned PointerAddrSpace; ///< Address space of pointer argument
+
----------------
arsenm wrote:
> You could make this -1 and then check that instead of a separate isPointer field, but I doubt that will actually save any space
It would also be inconsistent with how ByVal is handled, so I think I'll leave it as is for now.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58983/new/

https://reviews.llvm.org/D58983





More information about the llvm-commits mailing list