[PATCH] D60067: [llvm-symbolizer] Add llvm-addr2line.

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin marked an inline comment as done.
ikudrin added inline comments.


================
Comment at: tools/llvm-symbolizer/llvm-symbolizer.cpp:230
     Printer << (error(ResOrErr) ? DIInliningInfo() : ResOrErr.get());
+  } else if (IsAddr2Line) {
+    // With ClPrintFunctions == FunctionNameKind::LinkageName (default)
----------------
rupprecht wrote:
> I think this should be `else if (ClOutputStyle == OutputStyle::GNU)`, if someone wants to use `llvm-symbolizer` directly but still have GNU addr2line compatability.
I'm not sure. Output style should define the way the information is displayed, but not affect the information itself. It'd be a bit unexpected, I think.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60067/new/

https://reviews.llvm.org/D60067