[PATCH] D60684: [llvm-readobj] Reapply: Improve error message for --string-dump

Stephen Tozer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 15 03:53:48 PDT 2019


StephenTozer created this revision.
StephenTozer added reviewers: jhenderson, rupprecht, grimar, Higuoxing.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This is a resubmission of a previous patch that caused test failures, with only the fixes for the relevant tests included.

Previous review with full changelist: https://reviews.llvm.org/D59946


Repository:
  rL LLVM

https://reviews.llvm.org/D60684

Files:
  llvm/test/Object/corrupt.test


Index: llvm/test/Object/corrupt.test
===================================================================
--- llvm/test/Object/corrupt.test
+++ llvm/test/Object/corrupt.test
@@ -23,7 +23,7 @@
 RUN: not llvm-readobj %p/Inputs/corrupt-version.elf-x86_64 -dt \
 RUN:     2>&1 | FileCheck --check-prefix=VER %s
 
-VER: Error reading file: Invalid version entry.
+VER: error: Invalid version entry
 
 
 // The file is missing the dynamic string table but has references to it.
@@ -62,11 +62,11 @@
 RUN:   %p/Inputs/corrupt-invalid-dynamic-table-offset.elf.x86-64 2>&1 | \
 RUN:   FileCheck --check-prefix=DYN-TABLE-OFFSET %s
 
-DYN-TABLE-OFFSET: Invalid data was encountered while parsing the file.
+DYN-TABLE-OFFSET: error: Invalid data was encountered while parsing the file
 
 
 RUN: not llvm-readobj -dyn-relocations \
 RUN:   %p/Inputs/corrupt-invalid-dynamic-table-too-large.elf.x86-64 2>&1 | \
 RUN:   FileCheck --check-prefix=DYN-TABLE-TOO-LARGE %s
 
-DYN-TABLE-TOO-LARGE: Invalid data was encountered while parsing the file.
+DYN-TABLE-TOO-LARGE: error: Invalid data was encountered while parsing the file


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60684.195122.patch
Type: text/x-patch
Size: 1109 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190415/5b0fc458/attachment.bin>


More information about the llvm-commits mailing list