[PATCH] D60633: [AMDGPU] Avoid DAG combining assert with fneg(fadd(A,0))

Tim Renouf via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 15 03:06:09 PDT 2019


tpr added a comment.

I have cut down the test a bit more and put it into fneg-combines.ll. I did not manage to repro any problems with the other cases that I added fixes for.

I don't have a massive amount of time to spend on this. Would you prefer I land it as is, without tests for the other cases, or remove the precautionary fix for those cases and wait for someone else to possibly encounter them?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60633/new/

https://reviews.llvm.org/D60633





More information about the llvm-commits mailing list