[PATCH] D60614: [llvm-readelf] Fix dumping of SHN_XINDEX symbols
Jordan Rupprecht via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 15 01:59:00 PDT 2019
rupprecht added inline comments.
================
Comment at: test/tools/llvm-readobj/many-sections2.s:8
+
+.irp i, 0, 1, 2, 3, 4, 5, 6,
+ .irp j, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9,
----------------
My only concern with this patch: how long does this test take to run, specifically, how long does llvm-mc take to generate a file with this many sections? I've run into a similar issue in the past, where I wanted to create a test like this, but generating the test file from something like this took an absurd amount of time.
If it's fast, that'd be great (and if so, this patch LGTM). Maybe I'll dust off my old semi-abandoned patch and try to use this...
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60614/new/
https://reviews.llvm.org/D60614
More information about the llvm-commits
mailing list