[PATCH] D60628: [LLD] [COFF] Link crtend.o as the last object file

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 15 00:39:21 PDT 2019


mstorsjo added a comment.

In D60628#1466036 <https://reviews.llvm.org/D60628#1466036>, @ruiu wrote:

> I don't think you have to call std::stable_sort. Something like this should suffice.
>
>   for (size_t I = 0, E = InputFiles.size(); I != E; ++I) {
>     InputFile *File = InputFiles[I];
>     if (File.getName() != "crtend.o")
>       continue;
>     InputFiles.erase(i);
>     InputFiles.push_back(File);
>     break;
>   }


Thanks, that actually is very sensible and straightforward.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60628/new/

https://reviews.llvm.org/D60628





More information about the llvm-commits mailing list