[PATCH] D60652: [AMDGPU] Fixed incorrect test in vcnd/vcmp optimization

Tim Renouf via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 13 09:32:19 PDT 2019


tpr created this revision.
Herald added subscribers: llvm-commits, t-tye, dstuttard, yaxunl, nhaehnle, wdng, jvesely, kzhuravl, arsenm.
Herald added a project: LLVM.

This fixes a test I introduced in change D59191 <https://reviews.llvm.org/D59191> (that added src0 and
src1 modifiers to the v_cndmask instruction for disassembly purposes).

Spotted by David Binderman in bug 41488.

Change-Id: I6ac95e66cd84e812ed3359ad57bcd0e13198ba0c


Repository:
  rL LLVM

https://reviews.llvm.org/D60652

Files:
  lib/Target/AMDGPU/SIOptimizeExecMaskingPreRA.cpp


Index: lib/Target/AMDGPU/SIOptimizeExecMaskingPreRA.cpp
===================================================================
--- lib/Target/AMDGPU/SIOptimizeExecMaskingPreRA.cpp
+++ lib/Target/AMDGPU/SIOptimizeExecMaskingPreRA.cpp
@@ -223,7 +223,7 @@
     return AMDGPU::NoRegister;
 
   if (TII->hasModifiersSet(*Sel, AMDGPU::OpName::src0_modifiers) ||
-      TII->hasModifiersSet(*Sel, AMDGPU::OpName::src0_modifiers))
+      TII->hasModifiersSet(*Sel, AMDGPU::OpName::src1_modifiers))
     return AMDGPU::NoRegister;
 
   Op1 = TII->getNamedOperand(*Sel, AMDGPU::OpName::src0);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60652.195018.patch
Type: text/x-patch
Size: 580 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190413/8968aead/attachment.bin>


More information about the llvm-commits mailing list