[PATCH] D60487: [llvm] Prevent duplicate files in debug line header in dwarf 5: another attempt

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 11 04:41:52 PDT 2019


MaskRay added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp:1013
+  else
+    return Prologue.FileNames[Index - 1];
+}
----------------
For DWARF<5, if we make `FileNames[0]` a placeholder (i.e. waste the first entry), would that make the logic simpler? e.g. we may not need the two functions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60487/new/

https://reviews.llvm.org/D60487





More information about the llvm-commits mailing list