[llvm] r357833 - [Symbolize] Uniquify sorted vector<pair<SymbolDesc, StringRef>>

[Fangrui Song via llvm-commits]

Author: maskray
Date: Fri Apr  5 19:18:56 2019
New Revision: 357833

URL: http://llvm.org/viewvc/llvm-project?rev=357833&view=rev
Log:
[Symbolize] Uniquify sorted vector<pair<SymbolDesc, StringRef>>

Modified:
    llvm/trunk/lib/DebugInfo/Symbolize/SymbolizableObjectFile.cpp
    llvm/trunk/lib/DebugInfo/Symbolize/SymbolizableObjectFile.h

Modified: llvm/trunk/lib/DebugInfo/Symbolize/SymbolizableObjectFile.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/Symbolize/SymbolizableObjectFile.cpp?rev=357833&r1=357832&r2=357833&view=diff
==============================================================================
--- llvm/trunk/lib/DebugInfo/Symbolize/SymbolizableObjectFile.cpp (original)
+++ llvm/trunk/lib/DebugInfo/Symbolize/SymbolizableObjectFile.cpp Fri Apr  5 19:18:56 2019
@@ -81,10 +81,22 @@ SymbolizableObjectFile::create(object::O
 
   std::vector<std::pair<SymbolDesc, StringRef>> &Fs = res->Functions,
                                                 &Os = res->Objects;
-  llvm::sort(Fs);
-  Fs.erase(std::unique(Fs.begin(), Fs.end()), Fs.end());
-  llvm::sort(Os);
-  Os.erase(std::unique(Os.begin(), Os.end()), Os.end());
+  auto Uniquify = [](std::vector<std::pair<SymbolDesc, StringRef>> &S) {
+    // Sort by (Addr,Size,Name). If several SymbolDescs share the same Addr,
+    // pick the one with the largest Size. This helps us avoid symbols with no
+    // size information (Size=0).
+    llvm::sort(S);
+    auto I = S.begin(), E = S.end(), J = S.begin();
+    while (I != E) {
+      auto OI = I;
+      while (++I != E && OI->first.Addr == I->first.Addr) {
+      }
+      *J++ = I[-1];
+    }
+    S.erase(J, S.end());
+  };
+  Uniquify(Fs);
+  Uniquify(Os);
 
   return std::move(res);
 }
@@ -205,9 +217,6 @@ bool SymbolizableObjectFile::getNameFrom
                                                     uint64_t &Size) const {
   const auto &Symbols = Type == SymbolRef::ST_Function ? Functions : Objects;
   std::pair<SymbolDesc, StringRef> SD{{Address, UINT64_C(-1)}, StringRef()};
-  // SymbolDescs are sorted by (Addr,Size), if several SymbolDescs share the
-  // same Addr, pick the one with the largest Size. This helps us avoid symbols
-  // with no size information (Size=0).
   auto SymbolIterator = llvm::upper_bound(Symbols, SD);
   if (SymbolIterator == Symbols.begin())
     return false;

Modified: llvm/trunk/lib/DebugInfo/Symbolize/SymbolizableObjectFile.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/Symbolize/SymbolizableObjectFile.h?rev=357833&r1=357832&r2=357833&view=diff
==============================================================================
--- llvm/trunk/lib/DebugInfo/Symbolize/SymbolizableObjectFile.h (original)
+++ llvm/trunk/lib/DebugInfo/Symbolize/SymbolizableObjectFile.h Fri Apr  5 19:18:56 2019
@@ -75,9 +75,6 @@ private:
     // the following symbol.
     uint64_t Size;
 
-    bool operator==(const SymbolDesc &RHS) const {
-      return Addr == RHS.Addr && Size == RHS.Size;
-    }
     bool operator<(const SymbolDesc &RHS) const {
       return Addr != RHS.Addr ? Addr < RHS.Addr : Size < RHS.Size;
     }